adoralaura/go-urlsh
1
0
Fork 0
Code Issues 17 Pull requests 1 Projects Releases 3 Packages Wiki Activity Actions

Implement 2FA #6

New issue
Open
opened 2024-05-04 16:21:09 +02:00 by adoralaura · 0 comments
adoralaura commented 2024-05-04 16:21:09 +02:00
Owner
Copy link

Open TODOs:

  • Handle 2fa POST Request via JS, so that a message can be displayed when code was wrong
  • Rework scratch codes so that when they get used they get invalidated
  • Make it possible for the user to disable mfa
  • Make MFA Setup Flow more durable:
    • When reloading the setup page, scratch codes will be generated more than once
    • When you input a wrong TOTP code, Error message should be displayed inline. Also show busy submit button
    • mfakey cookie doesnt get deleted
    • when setting up 2fa, sometimes correct code is invalid and sometimes js doesnt do anything
  • Remove MFA cookie from setup flow OR attach it to session cookie (preferred)
Open TODOs: - [x] Handle 2fa POST Request via JS, so that a message can be displayed when code was wrong - [x] Rework scratch codes so that when they get used they get invalidated - [x] Make it possible for the user to disable mfa - [ ] Make MFA Setup Flow more durable: - [ ] When reloading the setup page, scratch codes will be generated more than once - [x] When you input a wrong TOTP code, Error message should be displayed inline. Also show busy submit button - [ ] mfakey cookie doesnt get deleted - [ ] when setting up 2fa, sometimes correct code is invalid and sometimes js doesnt do anything - [ ] Remove MFA cookie from setup flow OR attach it to session cookie (preferred)
adoralaura added the
enhancement
 label 2024-05-04 16:21:15 +02:00
adoralaura added a new dependency 2024-05-04 16:23:42 +02:00
#7 WIP: Add Two Factor Authentication
adoralaura removed a dependency 2024-05-04 16:23:51 +02:00
#7 WIP: Add Two Factor Authentication
adoralaura self-assigned this 2024-05-04 17:30:52 +02:00
adoralaura added reference feature-2fa 2024-05-08 17:00:18 +02:00
adoralaura added this to the v0.2.0 milestone 2024-05-09 15:38:23 +02:00
Sign in to join this conversation.
feature-2fa
Branches Tags
Clear current reference
main
feature-2fa
Clear current reference
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

Something is not working

  
contribution welcome

Contributions are very welcome, get started here

  
documentation

Documentation for the project

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
good first issue

Interested in contributing? Get started here.

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

Security relevant issues

  
upstream

Related to an upstream repository, already reported there

No labels
bug
contribution welcome
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
upstream
Milestone
Clear milestone
No items
No milestone
v0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
adoralaura
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: adoralaura/go-urlsh#6
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?